Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2648263007: Add a flag to specify whether to show ARC Files app in launcher. (Closed)
Patch Set: Change the description again after discussion. Rebase on remote master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | components/arc/arc_features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2204 matching lines...) Expand 10 before | Expand all | Expand 10 after
2215 {"enable-touchscreen-calibration", IDS_FLAGS_TOUCHSCREEN_CALIBRATION_NAME, 2215 {"enable-touchscreen-calibration", IDS_FLAGS_TOUCHSCREEN_CALIBRATION_NAME,
2216 IDS_FLAGS_TOUCHSCREEN_CALIBRATION_DESCRIPTION, kOsCrOS, 2216 IDS_FLAGS_TOUCHSCREEN_CALIBRATION_DESCRIPTION, kOsCrOS,
2217 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchCalibrationSetting)}, 2217 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchCalibrationSetting)},
2218 #endif // defined(OS_CHROMEOS) 2218 #endif // defined(OS_CHROMEOS)
2219 2219
2220 #if defined(OS_WIN) 2220 #if defined(OS_WIN)
2221 {"gdi-text-printing", IDS_FLAGS_GDI_TEXT_PRINTING, 2221 {"gdi-text-printing", IDS_FLAGS_GDI_TEXT_PRINTING,
2222 IDS_FLAGS_GDI_TEXT_PRINTING_DESCRIPTION, kOsWin, 2222 IDS_FLAGS_GDI_TEXT_PRINTING_DESCRIPTION, kOsWin,
2223 FEATURE_VALUE_TYPE(features::kGdiTextPrinting)} 2223 FEATURE_VALUE_TYPE(features::kGdiTextPrinting)}
2224 #endif 2224 #endif
2225
2226 #if defined(OS_CHROMEOS)
2227 {"show-arc-files-app", IDS_FLAGS_SHOW_ARC_FILES_APP_NAME,
2228 IDS_FLAGS_SHOW_ARC_FILES_APP_DESCRIPTION, kOsCrOS,
2229 FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)},
2230 #endif // defined(OS_CHROMEOS)
2231
2225 // NOTE: Adding new command-line switches requires adding corresponding 2232 // NOTE: Adding new command-line switches requires adding corresponding
2226 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2233 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2227 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2234 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2228 }; 2235 };
2229 2236
2230 class FlagsStateSingleton { 2237 class FlagsStateSingleton {
2231 public: 2238 public:
2232 FlagsStateSingleton() 2239 FlagsStateSingleton()
2233 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2240 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2234 ~FlagsStateSingleton() {} 2241 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2423 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2430 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2424 2431
2425 const FeatureEntry* GetFeatureEntries(size_t* count) { 2432 const FeatureEntry* GetFeatureEntries(size_t* count) {
2426 *count = arraysize(kFeatureEntries); 2433 *count = arraysize(kFeatureEntries);
2427 return kFeatureEntries; 2434 return kFeatureEntries;
2428 } 2435 }
2429 2436
2430 } // namespace testing 2437 } // namespace testing
2431 2438
2432 } // namespace about_flags 2439 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | components/arc/arc_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698