Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h

Issue 2648253005: Cleanup: remove state variables from inline_algorithm (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
index 8ec623c86e0645143da9639430d1f8083e914837..393136160c0ee1f4a637e1154c29068aae86eb0a 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
@@ -16,7 +16,6 @@ class NGBreakToken;
class NGConstraintSpace;
class NGFragmentBuilder;
class NGInlineNode;
-class NGLineBuilder;
// A class for inline layout (e.g. a anonymous block with inline-level children
// only).
@@ -46,16 +45,14 @@ class CORE_EXPORT NGInlineLayoutAlgorithm : public NGLayoutAlgorithm {
const ComputedStyle& Style() const { return *style_; }
bool LayoutCurrentChild();
ikilpatrick 2017/01/23 23:21:36 can you remove this? i forgot to in an earlier pat
atotic 2017/01/23 23:31:21 done
- NGConstraintSpace* CreateConstraintSpaceForCurrentChild() const;
+ NGConstraintSpace* CreateConstraintSpaceForCurrentChild(
ikilpatrick 2017/01/23 23:21:36 can you rename this to: CreateConstraintSpaceForCh
atotic 2017/01/23 23:31:21 done
+ const NGInlineNode& current_child) const;
RefPtr<const ComputedStyle> style_;
Member<NGInlineNode> first_child_;
Member<NGConstraintSpace> constraint_space_;
Member<NGBreakToken> break_token_;
Member<NGFragmentBuilder> builder_;
- Member<NGConstraintSpace> space_for_current_child_;
- Member<NGInlineNode> current_child_;
- Member<NGLineBuilder> line_builder_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698