Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: .gn

Issue 2648233006: Use default_args for configuring V8 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index f3ea8df868bae6916b37ebddd83620a188c0f79a..264ffacab2fa03e9fb0d88b04ee56c06231f937d 100644
--- a/.gn
+++ b/.gn
@@ -12,6 +12,32 @@ buildconfig = "//build/config/BUILDCONFIG.gn"
# in the source tree, e.g. for third party source trees.
secondary_source = "//build/secondary/"
+# These arguments override the default values for items in a declare_args
+# block. "gn args" in turn can override these.
+#
+# In general the value for a build arg in the declare_args block should be the
+# default. In some cases, a DEPS-ed in project will want different defaults for
+# being built as part of Chrome vs. being built standalone. In this case, the
+# Chrome defaults should go here. There should be no overrides here for
+# values declared in the main Chrome repository.
+default_args = {
+ v8_extra_library_files = [
+ # Dependencies used by the extra libraries. Putting them here causes them
+ # to be executed first during snapshot creation.
+ "//third_party/WebKit/Source/core/streams/CommonStrings.js",
Adam Rice 2017/01/26 03:59:01 Is it safe to assume that nothing is going to come
Michael Achenbach 2017/01/26 07:49:21 good question. Deferring to Brett
+
+ # Extra libraries.
+ "//third_party/WebKit/Source/core/streams/ByteLengthQueuingStrategy.js",
+ "//third_party/WebKit/Source/core/streams/CountQueuingStrategy.js",
+ "//third_party/WebKit/Source/core/streams/ReadableStream.js",
+ ]
+ v8_experimental_extra_library_files =
+ [ "//third_party/WebKit/Source/core/streams/WritableStream.js" ]
+ v8_enable_inspector = true
+ v8_enable_gdbjit = false
+ v8_imminent_deprecation_warnings = false
+}
+
# These are the targets to check headers for by default. The files in targets
# matching these patterns (see "gn help label_pattern" for format) will have
# their includes checked for proper dependencies when you run either
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698