Add black/whitelisting to apply_issue

Add black/whitelisting to apply_issue

BUG=370503
TESTS=
apply_issue.py --issue 243483007 --patchset 210001 --whitelst chrome/browser/chromeos/login/screen_locker.cc
apply_issue.py --issue 243483007 --patchset 210001 --blacklist chrome/browser/chromeos/login/screen_locker.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=268589

[Ryan Tseng, 2014-05-06 18:01:50]

agable review, maruel fyi (since git blame checkout.py | grep maruel | wc -l
returns 670)

[M-A Ruel, 2014-05-06 18:49:08]

https://codereview.chromium.org/264823003/diff/1/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/264823003/diff/1/apply_issue.py#newcode90
apply_issue.py:90: parser.add_option('--whitelist', action='append',
I recommend using default=[] on both, otherwise option.whitelist is None when no
argument is provided, which is occasionally annoying.

https://codereview.chromium.org/264823003/diff/1/checkout.py
File checkout.py (right):

https://codereview.chromium.org/264823003/diff/1/checkout.py#newcode135
checkout.py:135: name=None, email=None, whitelist=None, blacklist=None):
I think you are doing it at the wrong abstraction level. You should clean up the
patches object first. It's not at application time that filtering should be
done.

[Ryan Tseng, 2014-05-06 19:31:52]

Moved patchset filtering to apply_issue.py

Also updated the assert message in checkout.py

https://codereview.chromium.org/264823003/diff/1/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/264823003/diff/1/apply_issue.py#newcode90
apply_issue.py:90: parser.add_option('--whitelist', action='append',
On 2014/05/06 18:49:08, M-A Ruel wrote:
> I recommend using default=[] on both, otherwise option.whitelist is None when
no
> argument is provided, which is occasionally annoying.

Done.

https://codereview.chromium.org/264823003/diff/1/checkout.py
File checkout.py (right):

https://codereview.chromium.org/264823003/diff/1/checkout.py#newcode135
checkout.py:135: name=None, email=None, whitelist=None, blacklist=None):
On 2014/05/06 18:49:08, M-A Ruel wrote:
> I think you are doing it at the wrong abstraction level. You should clean up
the
> patches object first. It's not at application time that filtering should be
> done.

Done.

[M-A Ruel, 2014-05-06 19:34:59]

lgtm

[Ryan Tseng, 2014-05-06 19:43:31]

The CQ bit was checked by hinoka@google.com

[commit-bot: I haz the power, 2014-05-06 19:43:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hinoka@chromium.org/264823003/40001

[commit-bot: I haz the power, 2014-05-06 19:46:17]

Change committed as 268589