Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: components/arc/arc_util_unittest.cc

Issue 2648213004: Migrate --enable-arc and --arc-available part 1. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_util_unittest.cc
diff --git a/components/arc/arc_util_unittest.cc b/components/arc/arc_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5fd4cdd86de3a80be8cebded22f8a490b3c7a298
--- /dev/null
+++ b/components/arc/arc_util_unittest.cc
@@ -0,0 +1,83 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/arc/arc_util.h"
+
+#include <memory>
+
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/test/scoped_command_line.h"
+#include "base/test/scoped_feature_list.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+class ArcUtilTest : public testing::Test {
+ public:
+ ArcUtilTest() = default;
+ ~ArcUtilTest() override = default;
+
+ void SetUp() override {
+ scoped_command_line_ = base::MakeUnique<base::test::ScopedCommandLine>();
+ }
+
+ void TearDown() override { scoped_command_line_.reset(); }
+
+ private:
+ std::unique_ptr<base::test::ScopedCommandLine> scoped_command_line_;
+
+ DISALLOW_COPY_AND_ASSIGN(ArcUtilTest);
+};
+
+// Test --arc-available with EnableARC feature combination.
+TEST_F(ArcUtilTest, IsArcAvailable_Installed) {
hidehiko 2017/01/24 10:57:36 Note: these sub-test are named after the discussio
+ auto* command_line = base::CommandLine::ForCurrentProcess();
+
+ // If ARC is not installed, IsArcAvailable() should return false,
+ // regardless of EnableARC feature.
+ command_line->InitFromArgv({""});
+
+ // Not availble, by-default.
+ EXPECT_FALSE(IsArcAvailable());
+
+ {
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitFromCommandLine("EnableARC", "");
+ EXPECT_FALSE(IsArcAvailable());
+ }
+ {
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitFromCommandLine("", "EnableARC");
+ EXPECT_FALSE(IsArcAvailable());
+ }
+
+ // If ARC is installed, IsArcAvailable() should return true when EnableARC
+ // feature is set.
+ command_line->InitFromArgv({"", "--arc-available"});
+
+ // Not available, by-default, too.
+ EXPECT_FALSE(IsArcAvailable());
+
+ {
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitFromCommandLine("EnableARC", "");
+ EXPECT_TRUE(IsArcAvailable());
+ }
+ {
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitFromCommandLine("", "EnableARC");
+ EXPECT_FALSE(IsArcAvailable());
+ }
+}
+
+TEST_F(ArcUtilTest, IsArcAvailable_OfficialSupport) {
+ // Regardless of FeatureList, IsArcAvailable() should return true.
+ auto* command_line = base::CommandLine::ForCurrentProcess();
+ command_line->InitFromArgv({"", "--enable-arc"});
+ EXPECT_TRUE(IsArcAvailable());
+}
+
+} // namespace arc

Powered by Google App Engine
This is Rietveld 408576698