Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: content/browser/geolocation/network_location_request.cc

Issue 26482003: Geolocation: log the number of wifi access points used to determine location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use UMA_HISTOGRAM_CUSTOM_COUNTS. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/geolocation/network_location_request.cc
diff --git a/content/browser/geolocation/network_location_request.cc b/content/browser/geolocation/network_location_request.cc
index 9418a3f537d0917640606af8dec7989b25ff1592..5ec9167f435893180ef1149e754aef2ff426e597 100644
--- a/content/browser/geolocation/network_location_request.cc
+++ b/content/browser/geolocation/network_location_request.cc
@@ -58,6 +58,11 @@ void RecordUmaResponseCode(int code) {
code);
}
+void RecordUmaAccessPoints(int count) {
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Geolocation.NetworkLocationRequest.AccessPoints",
+ count, 0, 10, 11);
timvolodine 2013/10/10 12:00:43 could we use some constants here, like similar to
Michael van Ouwerkerk 2013/10/16 14:35:30 Done.
+}
+
// Local functions
// Creates the request url to send to the server.
GURL FormRequestURL(const GURL& url);
@@ -107,6 +112,7 @@ bool NetworkLocationRequest::MakeRequest(const string16& access_token,
const WifiData& wifi_data,
const base::Time& timestamp) {
RecordUmaEvent(NETWORK_LOCATION_REQUEST_EVENT_REQUEST_START);
+ RecordUmaAccessPoints(wifi_data.access_point_data.size());
if (url_fetcher_ != NULL) {
DVLOG(1) << "NetworkLocationRequest : Cancelling pending request";
RecordUmaEvent(NETWORK_LOCATION_REQUEST_EVENT_REQUEST_CANCEL);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698