Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/safe_browsing_db/remote_database_manager.cc

Issue 2648193002: SafeBrowsing: Move enabled_ to base class DB Manager (Closed)
Patch Set: Fix compile error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/remote_database_manager.cc
diff --git a/components/safe_browsing_db/remote_database_manager.cc b/components/safe_browsing_db/remote_database_manager.cc
index 87f3c4167adc42a135092348d3bcc6a4509574ae..dd6f37f339ee8fab848608fbc3fc14078a04e47f 100644
--- a/components/safe_browsing_db/remote_database_manager.cc
+++ b/components/safe_browsing_db/remote_database_manager.cc
@@ -98,8 +98,7 @@ void RemoteSafeBrowsingDatabaseManager::ClientRequest::OnRequestDone(
//
// TODO(nparker): Add more tests for this class
-RemoteSafeBrowsingDatabaseManager::RemoteSafeBrowsingDatabaseManager()
- : enabled_(false) {
+RemoteSafeBrowsingDatabaseManager::RemoteSafeBrowsingDatabaseManager() {
// Decide which resource types to check. These two are the minimum.
resource_types_to_check_.insert(content::RESOURCE_TYPE_MAIN_FRAME);
resource_types_to_check_.insert(content::RESOURCE_TYPE_SUB_FRAME);
@@ -280,7 +279,6 @@ void RemoteSafeBrowsingDatabaseManager::StartOnIOThread(
const V4ProtocolConfig& config) {
VLOG(1) << "RemoteSafeBrowsingDatabaseManager starting";
SafeBrowsingDatabaseManager::StartOnIOThread(request_context_getter, config);
- enabled_ = true;
}
void RemoteSafeBrowsingDatabaseManager::StopOnIOThread(bool shutdown) {
@@ -295,7 +293,6 @@ void RemoteSafeBrowsingDatabaseManager::StopOnIOThread(bool shutdown) {
DVLOG(1) << "Stopping: Invoking unfinished req for URL " << req->url();
req->OnRequestDone(SB_THREAT_TYPE_SAFE, ThreatMetadata());
}
- enabled_ = false;
SafeBrowsingDatabaseManager::StopOnIOThread(shutdown);
}

Powered by Google App Engine
This is Rietveld 408576698