Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2648053002: Remove old session history logic. (Closed)
Patch Set: Remove comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 6be34a6c69c289ae1c6f054bb9fd8cf7de09bd89..aee77f9f602d32f525a49d1b345bb531abfdc365 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -769,7 +769,6 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowWidget, OnShowWidget)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowFullscreenWidget,
OnShowFullscreenWidget)
- IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateState, OnUpdateState)
IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateTargetURL, OnUpdateTargetURL)
IPC_MESSAGE_HANDLER(ViewHostMsg_Close, OnClose)
IPC_MESSAGE_HANDLER(ViewHostMsg_RequestMove, OnRequestMove)
@@ -833,20 +832,6 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {
// decoupled.
}
-void RenderViewHostImpl::OnUpdateState(const PageState& state) {
- // Without this check, the renderer can trick the browser into using
- // filenames it can't access in a future session restore.
- auto* policy = ChildProcessSecurityPolicyImpl::GetInstance();
- int child_id = GetProcess()->GetID();
- if (!policy->CanReadAllFiles(child_id, state.GetReferencedFiles())) {
- bad_message::ReceivedBadMessage(
- GetProcess(), bad_message::RVH_CAN_ACCESS_FILES_OF_PAGE_STATE);
- return;
- }
-
- delegate_->UpdateState(this, state);
-}
-
void RenderViewHostImpl::OnUpdateTargetURL(const GURL& url) {
if (is_active_)
delegate_->UpdateTargetURL(this, url);
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698