ui/gfx/half_float.h - Issue 2648043002: Create FP16 LUTs when needed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/half_float.h

Issue 2648043002: Create FP16 LUTs when needed (Closed)

Patch Set: moved half-float conversion Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_COLOR_HALF_FLOAT_H_

	6 #define UI_GFX_COLOR_HALF_FLOAT_H_

	7

	8 #include <stdint.h>

	9 #include <stdlib.h>

	10

	11 #include "ui/gfx/gfx_export.h"

	12

	13 namespace gfx {

	14

	15 typedef uint16_t HalfFloat;

	16

	17 // Floats are expected to be within +/- 65535.0;

	18 GFX_EXPORT void FloatToHalfFloat(const float* input,

	19 HalfFloat* output,
	ccameron 2017/01/24 18:38:49 I'd vaguely prefer output to be a void, but let m I'd vaguely prefer output to be a void, but let me see how that goes when we merge in the stuff at https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph... that's the easy direction to change. hubbe 2017/01/24 18:47:46 That doesn't sound like a good idea to me. Any 2-b Show quoted text On 2017/01/24 18:38:49, ccameron wrote: > I'd vaguely prefer output to be a void, but let me see how that goes when we > merge in the stuff at > That doesn't sound like a good idea to me. Any 2-byte data type would be better than void. (Like maybe struct HalfFloat { unsigned char data[2]; } ) Show quoted text > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph... > > that's the easy direction to change. Yeah, I figured it would be better to fix that in a separate CL.
	20 size_t num);

	21 };

	22 #endif

OLD	NEW