Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: ios/web/shell/shell_web_client.h

Issue 2647943004: Return unique_ptr from WebClient::CreateWebMainParts() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/shell/shell_web_client.h
diff --git a/ios/web/shell/shell_web_client.h b/ios/web/shell/shell_web_client.h
index 4ab58d8c19eda24e63c26a79d7c9b3da36eed065..331bc6c8f05d3a6df45a61521152f4096635f5c9 100644
--- a/ios/web/shell/shell_web_client.h
+++ b/ios/web/shell/shell_web_client.h
@@ -21,7 +21,7 @@ class ShellWebClient : public WebClient {
~ShellWebClient() override;
// WebClient implementation.
- WebMainParts* CreateWebMainParts() override;
+ std::unique_ptr<web::WebMainParts> CreateWebMainParts() override;
std::string GetProduct() const override;
std::string GetUserAgent(bool desktop_user_agent) const override;
void AllowCertificateError(
@@ -35,7 +35,7 @@ class ShellWebClient : public WebClient {
ShellBrowserState* browser_state() const;
private:
- std::unique_ptr<ShellWebMainParts> web_main_parts_;
+ ShellWebMainParts* web_main_parts_; // weak
Eugene But (OOO till 7-30) 2017/01/20 22:11:41 nit: "weak" has very specific meaning on iOS and t
michaeldo 2017/01/23 17:30:54 Done.
DISALLOW_COPY_AND_ASSIGN(ShellWebClient);
};

Powered by Google App Engine
This is Rietveld 408576698