Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp.cc

Issue 264793017: Implements RTP header dumping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix leak Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host_tcp.cc
diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.cc b/content/browser/renderer_host/p2p/socket_host_tcp.cc
index 220b3cce6bbec0e1319582307c5189b3cb27b6a5..978f6269f5d65e4ae638f08136c8e549166424d7 100644
--- a/content/browser/renderer_host/p2p/socket_host_tcp.cc
+++ b/content/browser/renderer_host/p2p/socket_host_tcp.cc
@@ -45,9 +45,11 @@ bool IsPseudoTlsClientSocket(content::P2PSocketType type) {
namespace content {
P2PSocketHostTcpBase::P2PSocketHostTcpBase(
- IPC::Sender* message_sender, int id,
- P2PSocketType type, net::URLRequestContextGetter* url_context)
- : P2PSocketHost(message_sender, id),
+ IPC::Sender* message_sender,
+ int socket_id,
+ P2PSocketType type,
+ net::URLRequestContextGetter* url_context)
+ : P2PSocketHost(message_sender, socket_id),
write_pending_(false),
connected_(false),
type_(type),
@@ -287,6 +289,9 @@ void P2PSocketHostTcpBase::OnPacket(const std::vector<char>& data) {
message_sender_->Send(new P2PMsg_OnDataReceived(
id_, remote_address_.ip_address, data, base::TimeTicks::Now()));
+
+ if (dump_incoming_rtp_packet_)
+ DumpRtpPacket(&data[0], data.size(), true);
}
// Note: dscp is not actually used on TCP sockets as this point,
@@ -423,10 +428,11 @@ bool P2PSocketHostTcpBase::SetOption(P2PSocketOption option, int value) {
}
}
-P2PSocketHostTcp::P2PSocketHostTcp(
- IPC::Sender* message_sender, int id,
- P2PSocketType type, net::URLRequestContextGetter* url_context)
- : P2PSocketHostTcpBase(message_sender, id, type, url_context) {
+P2PSocketHostTcp::P2PSocketHostTcp(IPC::Sender* message_sender,
+ int socket_id,
+ P2PSocketType type,
+ net::URLRequestContextGetter* url_context)
+ : P2PSocketHostTcpBase(message_sender, socket_id, type, url_context) {
DCHECK(type == P2P_SOCKET_TCP_CLIENT ||
type == P2P_SOCKET_SSLTCP_CLIENT ||
type == P2P_SOCKET_TLS_CLIENT);
@@ -469,9 +475,11 @@ void P2PSocketHostTcp::DoSend(const net::IPEndPoint& to,
// P2PSocketHostStunTcp
P2PSocketHostStunTcp::P2PSocketHostStunTcp(
- IPC::Sender* message_sender, int id,
- P2PSocketType type, net::URLRequestContextGetter* url_context)
- : P2PSocketHostTcpBase(message_sender, id, type, url_context) {
+ IPC::Sender* message_sender,
+ int socket_id,
+ P2PSocketType type,
+ net::URLRequestContextGetter* url_context)
+ : P2PSocketHostTcpBase(message_sender, socket_id, type, url_context) {
DCHECK(type == P2P_SOCKET_STUN_TCP_CLIENT ||
type == P2P_SOCKET_STUN_SSLTCP_CLIENT ||
type == P2P_SOCKET_STUN_TLS_CLIENT);
@@ -539,6 +547,9 @@ void P2PSocketHostStunTcp::DoSend(const net::IPEndPoint& to,
memcpy(buffer->data() + data.size(), padding, pad_bytes);
}
WriteOrQueue(buffer);
+
+ if (dump_outgoing_rtp_packet_)
+ DumpRtpPacket(buffer->data(), data.size(), false);
}
int P2PSocketHostStunTcp::GetExpectedPacketSize(
« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_tcp.h ('k') | content/browser/renderer_host/p2p/socket_host_tcp_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698