Implements RTP header dumping.

chrome/browser/media/webrtc_log_uploader.h

Index: chrome/browser/media/webrtc_log_uploader.h
diff --git a/chrome/browser/media/webrtc_log_uploader.h b/chrome/browser/media/webrtc_log_uploader.h
index 40d95547bf78a001dc88f6b36d3810394249ea10..3ff215282997ca7fa800284f4a4180f0fcf4a647 100644
--- a/chrome/browser/media/webrtc_log_uploader.h
+++ b/chrome/browser/media/webrtc_log_uploader.h
@@ -27,6 +27,13 @@ class URLFetcher;
 
 typedef struct z_stream_s z_stream;
 
+struct WebRtcRtpDumpDescription {
+  WebRtcRtpDumpDescription(const std::string& name, const base::FilePath& path);
+
+  std::string name;

[tommi (sloooow) - chröme, 2014/05/17 10:18:37]

would be good to document these.  what does the path represent? and name of
what?

I'd still like to make these members const and I think we can do that by not
using std::vector.

[jiayl, 2014/05/19 17:32:59]

Added comments.

+  base::FilePath path;
+};
+
 // Used when uploading is done to perform post-upload actions. |log_path| is
 // also used pre-upload.
 struct WebRtcLogUploadDoneData {
@@ -34,6 +41,7 @@ struct WebRtcLogUploadDoneData {
   ~WebRtcLogUploadDoneData();
 
   base::FilePath log_path;
+  std::vector<WebRtcRtpDumpDescription> rtp_dumps;

[tommi (sloooow) - chröme, 2014/05/17 10:18:37]

Instead of implicitly adding data copy, can we use ScopedVector instead?

[jiayl, 2014/05/19 17:32:59]

It'll make WebRtcLogUploadDoneData not copy-able, which will make it not working
with std::map, i.e. UploadDoneDataMap.

I don't see the benefits of doing that, considering the added complexity.

   WebRtcLoggingHandlerHost::UploadDoneCallback callback;
   scoped_refptr<WebRtcLoggingHandlerHost> host;
   std::string local_log_id;
@@ -99,12 +107,9 @@ class WebRtcLogUploader : public net::URLFetcherDelegate {
   // to RFC 2046.
   void SetupMultipart(std::string* post_data,
                       const std::vector<uint8>& compressed_log,
+                      const std::vector<WebRtcRtpDumpDescription>& rtp_dumps,

[tommi (sloooow) - chröme, 2014/05/17 10:18:37]

ScopedVector?

[jiayl, 2014/05/19 17:32:59]

See above.

                       const std::map<std::string, std::string>& meta_data);
 
-  // Adds |compressed_log| to |post_data|.
-  void AddLogData(std::string* post_data,
-                  const std::vector<uint8>& compressed_log);
-
   void CompressLog(std::vector<uint8>* compressed_log,
                    uint8* input,
                    uint32 input_size);