Implements RTP header dumping.

chrome/browser/media/webrtc_rtp_dump_handler.h

Index: chrome/browser/media/webrtc_rtp_dump_handler.h
diff --git a/chrome/browser/media/webrtc_rtp_dump_handler.h b/chrome/browser/media/webrtc_rtp_dump_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..0d0b7480f8e6409b86540d8065b5dc16ce5e2a14
--- /dev/null
+++ b/chrome/browser/media/webrtc_rtp_dump_handler.h
@@ -0,0 +1,128 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_WEBRTC_RTP_DUMP_HANDLER_H_
+#define CHROME_BROWSER_MEDIA_WEBRTC_RTP_DUMP_HANDLER_H_
+
+#include "base/basictypes.h"
+#include "base/callback.h"
+#include "base/files/file_path.h"
+
+class WebRtcRtpDumpWriter;
+
+// WebRtcRtpDumpHandler handles operations regarding the WebRTC RTP dump:
+// - Starts or stops the RTP dumping on behalf of the client.
+// - Stops the RTP dumping when the max dump file size is reached.
+// - Writes the dump file.
+// - Provides the dump file to the client code to be uploaded when
+//   ReleaseRtpDump is called.
+// - Cleans up the dump file if not transferred to the client before the object
+//   is destroyed.
+//
+// Must be created/used/destroyed on the browser IO thread.
+class WebRtcRtpDumpHandler {
+ public:
+  typedef base::Callback<void(bool, const std::string&)> GenericDoneCallback;
+
+  enum PacketType {
+    PACKET_TYPE_INCOMING_ONLY,
+    PACKET_TYPE_OUTGOING_ONLY,
+    PACKET_TYPE_BOTH,
+  };
+
+  struct ReleasedDumps {
+    ReleasedDumps() {}
+
+    base::FilePath incoming_dump_path;
+    base::FilePath outgoing_dump_path;
+  };
+
+  static bool TypeContainsIncoming(PacketType type);

[Henrik Grunell, 2014/05/15 14:36:34]

Can these be made ordinary functions in the implementation file?

[jiayl, 2014/05/15 23:06:22]

Done.

+  static bool TypeContainsOutgoing(PacketType type);
+
+  // The caller must make sure |dump_dir| exists. RTP dump files are saved under
+  // |dump_dir| as "rtpdump_$DIRECTION_$TIMESTAMP.gz", where $DIRECTION is
+  // 'send' for outgoing dump or 'recv' for incoming dump. $TIMESTAMP is the
+  // dump started time converted to a double number in microsecond precision,
+  // which should guarantee the uniqueness across tabs and dump streams in
+  // practice.
+  explicit WebRtcRtpDumpHandler(const base::FilePath& dump_dir);
+  virtual ~WebRtcRtpDumpHandler();
+
+  // Starts the specified type of dumping. Incoming/outgoing dumping can be
+  // started separately. Returns true if called in a valid state, i.e.
+  // - if type.incoming == true, incoming dumping has not been started, and

[Henrik Grunell, 2014/05/15 14:36:34]

Update comment for enum change.

[jiayl, 2014/05/15 23:06:22]

Done.

+  //   outgoing dumping is not started or ongoing, returns true.
+  // - if type.outgoing == true, outgoing dumping has not been started, and
+  //   incoming dumping is not started or ongoing, returns true.
+  // - returns false in all other cases.
+  bool StartDump(PacketType type, std::string* error_message);
+
+  // Stops the specified type of dumping. Incoming/outgoing dumping can be
+  // stopped separately. Returns asynchronously through |callback|, where
+  // |success| is true if StopDump is called in a valid state.
+  void StopDump(PacketType type, const GenericDoneCallback& callback);
+
+  // Releases all the dumps to the caller and resets the state.
+  // It should only be called when both incoming and outgoing dumping has been
+  // stopped. Returns the dump file paths if called in a valid state.
+  //
+  // The caller will own the dump file after the method returns. If ReleaseDump
+  // returns false or not called before this object goes away, the dump file
+  // will be deleted by this object.
+  ReleasedDumps ReleaseDumps();
+
+  // Adds an RTP packet to the dump. The caller must make sure it's a valid RTP
+  // packet.
+  void OnRtpPacket(const uint8* packet_header,
+                   size_t header_length,
+                   size_t packet_length,
+                   bool incoming);
+
+ private:
+  friend class WebRtcRtpDumpHandlerTest;
+
+  // State transitions:
+  // initial --> STATE_NONE
+  // StartDump --> STATE_STARTED
+  // StopDump --> STATE_STOPPED
+  // ReleaseDump --> STATE_RELEASING
+  // ReleaseDump done --> STATE_NONE
+  enum State {
+    STATE_NONE,
+    STATE_STARTED,
+    STATE_STOPPING,
+    STATE_STOPPED,
+  };
+
+  // For unit test to inject a fake writer.
+  void SetDumpWriterForTesting(scoped_ptr<WebRtcRtpDumpWriter> writer);
+
+  // Callback from the dump writer when the max dump size is reached.
+  void OnMaxDumpSizeReached();
+
+  // Callback from the dump writer when ending a dump finishes. Calls the
+  // |callback| if all types of dump are ended.
+  void OnDumpEnded(const GenericDoneCallback& callback,
+                   bool incoming,
+                   bool succeeded);
+
+  // The directory containing the dump files.
+  const base::FilePath dump_dir_;
+
+  // The dump file paths.
+  base::FilePath incoming_dump_path_;
+  base::FilePath outgoing_dump_path_;
+
+  // The states of the incoming and outgoing dump.
+  State incoming_state_;
+  State outgoing_state_;
+
+  // The object used to create and write the dump file.
+  scoped_ptr<WebRtcRtpDumpWriter> dump_writer_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebRtcRtpDumpHandler);
+};
+
+#endif  // CHROME_BROWSER_MEDIA_WEBRTC_RTP_DUMP_HANDLER_H_