Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3111)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Issue 264793017: Implements RTP header dumping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
index 9d02674b65a561a2a92fde4c19d7f6d97cb503c2..c3f1d69c91d0674c2069985506b28e8bda520c31 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
@@ -298,6 +298,9 @@ bool WebrtcLoggingPrivateStartRtpDumpFunction::RunAsync() {
params->outgoing,
callback));
+ // This call cannot fail and we do not need to block the callback for it.
+ host->StartRtpDump(params->incoming, params->outgoing);
+
return true;
}
@@ -339,6 +342,9 @@ bool WebrtcLoggingPrivateStopRtpDumpFunction::RunAsync() {
params->outgoing,
callback));
+ // This call cannot fail and we do not need to block the callback for it.
+ host->StopRtpDump(params->incoming, params->outgoing);
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698