chrome/browser/media/DEPS - Issue 264793017: Implements RTP header dumping.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/DEPS

Issue 264793017: Implements RTP header dumping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+media/audio",	2 "+media/audio",

3 "+media/base",	3 "+media/base",

4 "+media/cast",	4 "+media/cast",

	5 "+third_party/libjingle",
	Henrik Grunell 2014/05/05 14:38:03 I'm not so sure we should depend on libjingle here I'm not so sure we should depend on libjingle here. It's for the RTP dump writer, right? jiayl 2014/05/05 16:50:56 Correct. It already depends on third_party/webrtc, Show quoted text On 2014/05/05 14:38:03, Henrik Grunell wrote: > I'm not so sure we should depend on libjingle here. It's for the RTP dump > writer, right? Correct. It already depends on third_party/webrtc, so I think it should be fine for third_party/libjingle. Otherwise, we need to duplicate the code of RtpDumpWriter in Chrome. Henrik Grunell 2014/05/06 08:34:26 Yes, that's of course more convenient. It's probab Show quoted text On 2014/05/05 16:50:56, jiayl wrote: > On 2014/05/05 14:38:03, Henrik Grunell wrote: > > I'm not so sure we should depend on libjingle here. It's for the RTP dump > > writer, right? > > Correct. It already depends on third_party/webrtc, so I think it should be fine > for third_party/libjingle. Otherwise, we need to duplicate the code of > RtpDumpWriter in Chrome. Yes, that's of course more convenient. It's probably fine, but I suggest you check with someone (Tommi?) who knows more about the include rules. Maybe it can be limited to the specific folder the rtp writer resides in? tommi (sloooow) - chröme 2014/05/06 08:58:08 We're depending on libjingle on chromeos so I gues Show quoted text On 2014/05/06 08:34:26, Henrik Grunell wrote: > On 2014/05/05 16:50:56, jiayl wrote: > > On 2014/05/05 14:38:03, Henrik Grunell wrote: > > > I'm not so sure we should depend on libjingle here. It's for the RTP dump > > > writer, right? > > > > Correct. It already depends on third_party/webrtc, so I think it should be > fine > > for third_party/libjingle. Otherwise, we need to duplicate the code of > > RtpDumpWriter in Chrome. > > Yes, that's of course more convenient. It's probably fine, but I suggest you > check with someone (Tommi?) who knows more about the include rules. Maybe it can > be limited to the specific folder the rtp writer resides in? We're depending on libjingle on chromeos so I guess this is alright. Is there no way to do this in the renderer process instead? Adding a third party library to the browser makes it harder to protect against problems.
5 "+third_party/libyuv",	6 "+third_party/libyuv",

6 "+third_party/webrtc",	7 "+third_party/webrtc",

7 ]	8 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/media/webrtc_rtp_dump_handler.h » ('j') | chrome/browser/media/webrtc_rtp_dump_handler.h » ('J')