Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 264793015: Fix ObjectNotifierPerformChange leak after r21126 (Closed)

Created:
6 years, 7 months ago by adamk
Modified:
6 years, 7 months ago
Reviewers:
rafaelw, Jakob Kummerow
CC:
v8-dev, Toon Verwaest, rafaelw, danno
Visibility:
Public.

Description

Fix ObjectNotifierPerformChange leak after r21126 Due to overlapping names of natives and runtime functions, the wrong context was used for Notifier.prototype.performChange. The leak test has been augmented to properly cover the leaky case, and the test now passes. Also tightened up type checks in runtime.cc and removed Object.observe functions from knownIssues in fuzz-natives-part2.js. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21129

Patch Set 1 #

Patch Set 2 : Tighten acceptList argument type requirements, remove fuzz-natives blacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M src/object-observe.js View 3 chunks +4 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +13 lines, -10 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M test/mjsunit/fuzz-natives-part2.js View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
6 years, 7 months ago (2014-05-02 20:02:05 UTC) #1
rafaelw
thanks for catching this.
6 years, 7 months ago (2014-05-02 20:05:37 UTC) #2
adamk
CC danno fyi
6 years, 7 months ago (2014-05-02 21:10:33 UTC) #3
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-02 21:28:21 UTC) #4
adamk
6 years, 7 months ago (2014-05-02 21:29:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698