Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/password_manager/core/browser/log_router.h

Issue 264793010: Rename PasswordManagerLogger to LogReceiver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/log_router.h
diff --git a/components/password_manager/core/browser/log_router.h b/components/password_manager/core/browser/log_router.h
index c7ab218e4951433fd37ea73a7b3a13b2d79e2a67..06ca4e65e69781c0480de0591dd2b9ead268f8bd 100644
--- a/components/password_manager/core/browser/log_router.h
+++ b/components/password_manager/core/browser/log_router.h
@@ -13,16 +13,13 @@
namespace password_manager {
+class LogReceiver;
class PasswordManagerClient;
-class PasswordManagerLogger;
// The router stands between PasswordManagerClient instances and log receivers.
// During the process of saving a password, the password manager code generates
// the log strings, and passes them to the router. The router distributes the
// logs to the receivers for displaying.
-//
-// TODO(vabr): The receivers are objects of type PasswordManagerLogger. That
-// type should be renamed to LogReceiver instead.
class LogRouter {
public:
LogRouter();
@@ -46,16 +43,16 @@ class LogRouter {
// RegisterReceiver adds |receiver| to the right observer list, and returns
// the logs accumulated so far. (It returns by value, not const ref, to
// provide a snapshot as opposed to a link to |accumulated_logs_|.)
- std::string RegisterReceiver(PasswordManagerLogger* receiver);
+ std::string RegisterReceiver(LogReceiver* receiver);
// Remove |receiver| from the observers list.
- void UnregisterReceiver(PasswordManagerLogger* receiver);
+ void UnregisterReceiver(LogReceiver* receiver);
private:
// Observer lists for clients and receivers. The |true| in the template
// specialisation means that they will check that all observers were removed
// on destruction.
ObserverList<PasswordManagerClient, true> clients_;
- ObserverList<PasswordManagerLogger, true> receivers_;
+ ObserverList<LogReceiver, true> receivers_;
// Logs accumulated since the first receiver was registered.
std::string accumulated_logs_;
« no previous file with comments | « components/password_manager/core/browser/log_receiver.h ('k') | components/password_manager/core/browser/log_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698