Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: components/password_manager/core/browser/log_router.cc

Issue 264793010: Rename PasswordManagerLogger to LogReceiver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/log_router.h" 5 #include "components/password_manager/core/browser/log_router.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "components/password_manager/core/browser/log_receiver.h"
8 #include "components/password_manager/core/browser/password_manager_client.h" 9 #include "components/password_manager/core/browser/password_manager_client.h"
9 #include "components/password_manager/core/browser/password_manager_logger.h"
10 10
11 namespace password_manager { 11 namespace password_manager {
12 12
13 LogRouter::LogRouter() { 13 LogRouter::LogRouter() {
14 } 14 }
15 15
16 LogRouter::~LogRouter() { 16 LogRouter::~LogRouter() {
17 } 17 }
18 18
19 void LogRouter::ProcessLog(const std::string& text) { 19 void LogRouter::ProcessLog(const std::string& text) {
20 // This may not be called when there are no receivers (i.e., the router is 20 // This may not be called when there are no receivers (i.e., the router is
21 // inactive), because in that case the logs cannot be displayed. 21 // inactive), because in that case the logs cannot be displayed.
22 DCHECK(receivers_.might_have_observers()); 22 DCHECK(receivers_.might_have_observers());
23 accumulated_logs_.append(text); 23 accumulated_logs_.append(text);
24 FOR_EACH_OBSERVER( 24 FOR_EACH_OBSERVER(
25 PasswordManagerLogger, receivers_, LogSavePasswordProgress(text)); 25 LogReceiver, receivers_, LogSavePasswordProgress(text));
26 } 26 }
27 27
28 bool LogRouter::RegisterClient(PasswordManagerClient* client) { 28 bool LogRouter::RegisterClient(PasswordManagerClient* client) {
29 DCHECK(client); 29 DCHECK(client);
30 clients_.AddObserver(client); 30 clients_.AddObserver(client);
31 return receivers_.might_have_observers(); 31 return receivers_.might_have_observers();
32 } 32 }
33 33
34 void LogRouter::UnregisterClient(PasswordManagerClient* client) { 34 void LogRouter::UnregisterClient(PasswordManagerClient* client) {
35 DCHECK(clients_.HasObserver(client)); 35 DCHECK(clients_.HasObserver(client));
36 clients_.RemoveObserver(client); 36 clients_.RemoveObserver(client);
37 } 37 }
38 38
39 std::string LogRouter::RegisterReceiver(PasswordManagerLogger* receiver) { 39 std::string LogRouter::RegisterReceiver(LogReceiver* receiver) {
40 DCHECK(receiver); 40 DCHECK(receiver);
41 DCHECK(accumulated_logs_.empty() || receivers_.might_have_observers()); 41 DCHECK(accumulated_logs_.empty() || receivers_.might_have_observers());
42 42
43 if (!receivers_.might_have_observers()) { 43 if (!receivers_.might_have_observers()) {
44 FOR_EACH_OBSERVER( 44 FOR_EACH_OBSERVER(
45 PasswordManagerClient, clients_, OnLogRouterAvailabilityChanged(true)); 45 PasswordManagerClient, clients_, OnLogRouterAvailabilityChanged(true));
46 } 46 }
47 receivers_.AddObserver(receiver); 47 receivers_.AddObserver(receiver);
48 return accumulated_logs_; 48 return accumulated_logs_;
49 } 49 }
50 50
51 void LogRouter::UnregisterReceiver(PasswordManagerLogger* receiver) { 51 void LogRouter::UnregisterReceiver(LogReceiver* receiver) {
52 DCHECK(receivers_.HasObserver(receiver)); 52 DCHECK(receivers_.HasObserver(receiver));
53 receivers_.RemoveObserver(receiver); 53 receivers_.RemoveObserver(receiver);
54 if (!receivers_.might_have_observers()) { 54 if (!receivers_.might_have_observers()) {
55 accumulated_logs_.clear(); 55 accumulated_logs_.clear();
56 FOR_EACH_OBSERVER( 56 FOR_EACH_OBSERVER(
57 PasswordManagerClient, clients_, OnLogRouterAvailabilityChanged(false)); 57 PasswordManagerClient, clients_, OnLogRouterAvailabilityChanged(false));
58 } 58 }
59 } 59 }
60 60
61 } // namespace password_manager 61 } // namespace password_manager
OLDNEW
« no previous file with comments | « components/password_manager/core/browser/log_router.h ('k') | components/password_manager/core/browser/log_router_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698