Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: sync/api/sync_data.h

Issue 264793007: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory leak. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/attachments/fake_attachment_service.cc ('k') | sync/api/sync_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/sync_data.h
diff --git a/sync/api/sync_data.h b/sync/api/sync_data.h
index bb99b744571c100198e5ee60abd830bd88136abc..8795141076abd0da15d5a7f93648cff61653cc42 100644
--- a/sync/api/sync_data.h
+++ b/sync/api/sync_data.h
@@ -43,14 +43,19 @@ class SYNC_EXPORT SyncData {
// Default copy and assign welcome.
// Helper methods for creating SyncData objects for local data.
- // The sync tag must be a string unique to this datatype and is used as a node
+ //
+ // |sync_tag| Must be a string unique to this datatype and is used as a node
// identifier server-side.
+ //
// For deletes: |datatype| must specify the datatype who node is being
// deleted.
- // For adds/updates: the specifics must be valid and the non-unique title (can
- // be the same as sync tag) must be specfied.
- // Note: the non_unique_title is primarily for debug purposes, and will be
- // overwritten if the datatype is encrypted.
+ //
+ // For adds/updates: |specifics| must be valid and |non_unique_title| (can be
+ // the same as |sync_tag|) must be specfied. Note: |non_unique_title| is
+ // primarily for debug purposes, and will be overwritten if the datatype is
+ // encrypted.
+ //
+ // For data with attachments: |attachments| must not contain duplicates.
static SyncData CreateLocalDelete(
const std::string& sync_tag,
ModelType datatype);
« no previous file with comments | « sync/api/attachments/fake_attachment_service.cc ('k') | sync/api/sync_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698