runtime/vm/object.cc - Issue 2647913002: Optimizations to IC stub for unoptimized code performance on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2647913002: Optimizations to IC stub for unoptimized code performance on x64. (Closed)

Patch Set: Add MIPS and remove more overflow checks Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 69810fdf5e52e4f1c0a9d0174e5082ef65af3f60..499da7e951ffcd5a408940279fece9938511a488 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -13465,6 +13465,11 @@ intptr_t ICData::GetCountAt(intptr_t index) const {

const Array& data = Array::Handle(ic_data());

const intptr_t data_pos =

index * TestEntryLength() + CountIndexFor(NumArgsTested());

+ if (data_pos < 0) {

regis 2017/01/24 18:27:21 Can you explain with a comment how this is possibl

+ // Overflow.

+ SetCountAt(index, 0);

+ return 0;

+ }

return Smi::Value(Smi::RawCast(data.At(data_pos)));

}