Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2647853002: Delete third_party/codesighs/ (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete third_party/codesighs/ This tool to measure size of code was added in 2009, and there's no indication that anybody has used it at all since then. BUG= Review-Url: https://codereview.chromium.org/2647853002 Cr-Commit-Position: refs/heads/master@{#445009} Committed: https://chromium.googlesource.com/chromium/src/+/fd1eee2323b24d2203d431246177096de15a3308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8347 lines) Patch
M BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
D third_party/codesighs/BUILD.gn View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/codesighs/LICENSE View 1 chunk +0 lines, -567 lines 0 comments Download
D third_party/codesighs/Makefile.in View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/codesighs/README.chromium View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/codesighs/autosummary.unix.bash View 1 chunk +0 lines, -250 lines 0 comments Download
D third_party/codesighs/autosummary.win.bash View 1 chunk +0 lines, -211 lines 0 comments Download
D third_party/codesighs/basesummary.unix.bash View 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/codesighs/basesummary.win.bash View 1 chunk +0 lines, -224 lines 0 comments Download
D third_party/codesighs/codesighs.c View 1 chunk +0 lines, -1075 lines 0 comments Download
D third_party/codesighs/maptsvdifftool.c View 1 chunk +0 lines, -1311 lines 0 comments Download
D third_party/codesighs/msdump2symdb.c View 1 chunk +0 lines, -1090 lines 0 comments Download
D third_party/codesighs/msmap.h View 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/codesighs/msmap2tsv.c View 1 chunk +0 lines, -2237 lines 0 comments Download
D third_party/codesighs/nm2tsv.c View 1 chunk +0 lines, -505 lines 0 comments Download
D third_party/codesighs/nm_wrap_osx.pl View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/codesighs/readelf_wrap.pl View 1 chunk +0 lines, -192 lines 0 comments Download
M tools/licenses.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
aelias_OOO_until_Jul13
Hi thakis@, PTAL.
3 years, 11 months ago (2017-01-20 05:51:49 UTC) #5
Nico
lgtm
3 years, 11 months ago (2017-01-20 07:05:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647853002/1
3 years, 11 months ago (2017-01-20 07:05:10 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 07:40:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd1eee2323b24d2203d431246177...

Powered by Google App Engine
This is Rietveld 408576698