Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js |
| index 5625bfe5eaa20e13816b68afd06fc289196ed931..4a6762f41c3e31cdf08067781c2c841aac476e06 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js |
| @@ -307,7 +307,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox { |
| for (var i = firstRequestIndex; i < lastRequestIndex; i++) { |
| var rowOffset = this._rowHeight * i; |
| var node = nodes[i]; |
| - this._decorateRow(context, node, i, rowOffset - this._scrollTop); |
| + this._decorateRow(context, node, rowOffset - this._scrollTop); |
| var drawNodes = []; |
| if (node.hasChildren() && !node.expanded) |
| drawNodes = /** @type {!Array<!Network.NetworkNode>} */ (node.flatChildren()); |
| @@ -596,12 +596,11 @@ Network.NetworkWaterfallColumn = class extends UI.VBox { |
| /** |
| * @param {!CanvasRenderingContext2D} context |
| * @param {!Network.NetworkNode} node |
| - * @param {number} rowNumber |
| * @param {number} y |
| */ |
| - _decorateRow(context, node, rowNumber, y) { |
| - var isOddRow = rowNumber % 2 === 1; |
| - if (isOddRow && !node.hovered() && !node.isNavigationRequest() && !node.isOnInitiatorPath() && |
| + _decorateRow(context, node, y) { |
| + var isEvenRow = !node.isOdd(); |
| + if (isEvenRow && !node.hovered() && !node.isNavigationRequest() && !node.isOnInitiatorPath() && |
| !node.isOnInitiatedPath()) |
| return; |
| @@ -628,7 +627,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox { |
| return this._initiatedColor; |
| if (node.isNavigationRequest()) |
| return this._rowNavigationRequestColor; |
| - if (rowNumber % 2 === 1) |
| + if (isEvenRow) |
|
luoe
2017/01/20 18:05:49
Looks safe, but it used to check if row was odd.
allada
2017/01/20 19:53:45
Yes, it's not really "odd" or "even" any more beca
|
| return 'transparent'; |
| return this._rowStripeColor; |
| } |