Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2647803002: [Devtools] Fixed network to sort items as they are received. (Closed)
Patch Set: Merge branch 'GROUP_CONNECTION_ID_DEFAULT' into GROUP_SCROLL_PROPERLY Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkLogViewColumns = class { 7 Network.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!Network.NetworkLogView} networkLogView 9 * @param {!Network.NetworkLogView} networkLogView
10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 } 184 }
185 } 185 }
186 186
187 _redrawWaterfallColumn() { 187 _redrawWaterfallColumn() {
188 if (!this._waterfallRequestsAreStale) { 188 if (!this._waterfallRequestsAreStale) {
189 this._updateScrollerWidthIfNeeded(); 189 this._updateScrollerWidthIfNeeded();
190 this._waterfallColumn.update( 190 this._waterfallColumn.update(
191 this._activeScroller.scrollTop, this._eventDividersShown ? this._event Dividers : undefined); 191 this._activeScroller.scrollTop, this._eventDividersShown ? this._event Dividers : undefined);
192 return; 192 return;
193 } 193 }
194 this._syncScrollers();
194 var nodes = this._networkLogView.flatNodesList(); 195 var nodes = this._networkLogView.flatNodesList();
195 this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDivi ders, nodes); 196 this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDivi ders, nodes);
196 } 197 }
197 198
198 _createWaterfallHeader() { 199 _createWaterfallHeader() {
199 this._waterfallHeaderElement = this._waterfallColumn.contentElement.createCh ild('div', 'network-waterfall-header'); 200 this._waterfallHeaderElement = this._waterfallColumn.contentElement.createCh ild('div', 'network-waterfall-header');
200 this._waterfallHeaderElement.addEventListener('click', waterfallHeaderClicke d.bind(this)); 201 this._waterfallHeaderElement.addEventListener('click', waterfallHeaderClicke d.bind(this));
201 this._waterfallHeaderElement.addEventListener( 202 this._waterfallHeaderElement.addEventListener(
202 'contextmenu', event => this._innerHeaderContextMenu(new UI.ContextMenu( event))); 203 'contextmenu', event => this._innerHeaderContextMenu(new UI.ContextMenu( event)));
203 var innerElement = this._waterfallHeaderElement.createChild('div'); 204 var innerElement = this._waterfallHeaderElement.createChild('div');
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 return this._dataGrid; 259 return this._dataGrid;
259 } 260 }
260 261
261 sortByCurrentColumn() { 262 sortByCurrentColumn() {
262 this._sortHandler(); 263 this._sortHandler();
263 } 264 }
264 265
265 _sortHandler() { 266 _sortHandler() {
266 var columnId = this._dataGrid.sortColumnId(); 267 var columnId = this._dataGrid.sortColumnId();
267 this._networkLogView.removeAllNodeHighlights(); 268 this._networkLogView.removeAllNodeHighlights();
269 this._waterfallRequestsAreStale = true;
268 if (columnId === 'waterfall') { 270 if (columnId === 'waterfall') {
269 this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-des cending'); 271 this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-des cending');
270 272
271 if (this._dataGrid.sortOrder() === DataGrid.DataGrid.Order.Ascending) 273 if (this._dataGrid.sortOrder() === DataGrid.DataGrid.Order.Ascending)
272 this._waterfallColumnSortIcon.classList.add('sort-ascending'); 274 this._waterfallColumnSortIcon.classList.add('sort-ascending');
273 else 275 else
274 this._waterfallColumnSortIcon.classList.add('sort-descending'); 276 this._waterfallColumnSortIcon.classList.add('sort-descending');
275 277
276 this._waterfallRequestsAreStale = true;
277 var sortFunction = Network.NetworkRequestNode.RequestPropertyComparator.bi nd(null, this._activeWaterfallSortId); 278 var sortFunction = Network.NetworkRequestNode.RequestPropertyComparator.bi nd(null, this._activeWaterfallSortId);
278 this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscendin g()); 279 this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscendin g());
279 this._networkLogView.dataGridSorted(); 280 this._networkLogView.dataGridSorted();
280 return; 281 return;
281 } 282 }
282 283
283 var columnConfig = this._columns.find(columnConfig => columnConfig.id === co lumnId); 284 var columnConfig = this._columns.find(columnConfig => columnConfig.id === co lumnId);
284 if (!columnConfig || !columnConfig.sortingFunction) 285 if (!columnConfig || !columnConfig.sortingFunction)
285 return; 286 return;
286 287
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 /** 807 /**
807 * @enum {string} 808 * @enum {string}
808 */ 809 */
809 Network.NetworkLogViewColumns.WaterfallSortIds = { 810 Network.NetworkLogViewColumns.WaterfallSortIds = {
810 StartTime: 'startTime', 811 StartTime: 'startTime',
811 ResponseTime: 'responseReceivedTime', 812 ResponseTime: 'responseReceivedTime',
812 EndTime: 'endTime', 813 EndTime: 'endTime',
813 Duration: 'duration', 814 Duration: 'duration',
814 Latency: 'latency' 815 Latency: 'latency'
815 }; 816 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698