Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2647803002: [Devtools] Fixed network to sort items as they are received. (Closed)
Patch Set: Merge branch 'GROUP_CONNECTION_ID_DEFAULT' into GROUP_SCROLL_PROPERLY Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
836 836
837 for (var node of nodesToRefresh) 837 for (var node of nodesToRefresh)
838 node.refresh(); 838 node.refresh();
839 839
840 this._highlightNthMatchedRequestForSearch( 840 this._highlightNthMatchedRequestForSearch(
841 this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode) , false); 841 this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode) , false);
842 842
843 this._staleRequestIds = {}; 843 this._staleRequestIds = {};
844 this._updateSummaryBar(); 844 this._updateSummaryBar();
845 845
846 this._columns.dataChanged(); 846 if (nodesToInsert.size)
luoe 2017/01/20 18:05:48 Is this the only call to dataChanged? If so let's
allada 2017/01/20 19:53:45 Done.
847 this._columns.sortByCurrentColumn();
847 } 848 }
848 849
849 /** 850 /**
850 * @param {!Network.NetworkRequestNode} node 851 * @param {!Network.NetworkRequestNode} node
851 * @return {!Network.NetworkNode} 852 * @return {!Network.NetworkNode}
852 */ 853 */
853 _parentNodeForInsert(node) { 854 _parentNodeForInsert(node) {
854 if (!Runtime.experiments.isEnabled('networkGroupingRequests')) 855 if (!Runtime.experiments.isEnabled('networkGroupingRequests'))
855 return /** @type {!Network.NetworkNode} */ (this._dataGrid.rootNode()); 856 return /** @type {!Network.NetworkNode} */ (this._dataGrid.rootNode());
856 857
(...skipping 891 matching lines...) Expand 10 before | Expand all | Expand 10 after
1748 Running: 'running', 1749 Running: 'running',
1749 FromCache: 'from-cache' 1750 FromCache: 'from-cache'
1750 }; 1751 };
1751 1752
1752 /** @type {!Array<string>} */ 1753 /** @type {!Array<string>} */
1753 Network.NetworkLogView._searchKeys = 1754 Network.NetworkLogView._searchKeys =
1754 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]); 1755 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]);
1755 1756
1756 /** @typedef {function(!SDK.NetworkRequest): boolean} */ 1757 /** @typedef {function(!SDK.NetworkRequest): boolean} */
1757 Network.NetworkLogView.Filter; 1758 Network.NetworkLogView.Filter;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698