Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 26478004: Refine the GlobalEventHandlers test (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Refine the GlobalEventHandlers test http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-October/thread.html#40980 The conclusion of the WHATWG "Should onfoo event handler properties be on Element or HTMLElement?" thread was that not letting Element have these properties is more sane, because reflecting the corresponding content attributes for Element would be odd. Update the test to assert that Element does not have the properties, but that HTMLElement and SVGElement do. Also split the enumerate tests so that individual results can be seen. BUG=305112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -268 lines) Patch
M LayoutTests/fast/dom/global-event-handlers.html View 1 chunk +64 lines, -29 lines 0 comments Download
M LayoutTests/fast/dom/global-event-handlers-expected.txt View 1 chunk +472 lines, -239 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
For some context, here's my current plan for GlobalEventHandlers: 1. Update the test (this review) ...
5 years, 1 month ago (2013-10-11 10:36:24 UTC) #1
abarth-chromium
lgtm
5 years, 1 month ago (2013-10-11 18:22:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26478004/1
5 years, 1 month ago (2013-10-11 18:22:34 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2013-10-11 22:14:37 UTC) #4
Message was sent while issue was closed.
Change committed as 159478

Powered by Google App Engine
This is Rietveld 408576698