Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2647763003: Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered wit… (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project." This reverts commit 5290052550f89399f7c5ad86aeab73d6693c7057. Revert "Fixed segfault in Remove method." This reverts commit 203f1ba222810cfca4163d46f5da137688b39e6e. BUG= TBR=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c9a4374ed9c1cb543d7b8a7eb787ed6b45cf4a45

Patch Set 1 #

Patch Set 2 : Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered wit… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -506 lines) Patch
M runtime/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/bin/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +0 lines, -63 lines 0 comments Download
M runtime/vm/hash_map_test.cc View 2 chunks +0 lines, -61 lines 0 comments Download
M runtime/vm/malloc_hooks.h View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 1 chunk +4 lines, -251 lines 0 comments Download
D runtime/vm/malloc_hooks_test.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 1 chunk +4 lines, -26 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bkonyi
3 years, 11 months ago (2017-01-19 23:13:26 UTC) #1
bkonyi
Committed patchset #2 (id:20001) manually as c9a4374ed9c1cb543d7b8a7eb787ed6b45cf4a45 (presubmit successful).
3 years, 11 months ago (2017-01-19 23:17:39 UTC) #3
zra
3 years, 11 months ago (2017-01-19 23:19:14 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698