Issue 264773018: [New Multicolumn] Remove the term "balancing" from some member names.

Issue 264773018: [New Multicolumn] Remove the term "balancing" from some member names. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)

Modified:
6 years, 7 months ago

Reviewers:
Julien - ping for review, esprehn, ojan

CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[New Multicolumn] Remove the term "balancing" from some member names. This is in line with what it's called in RenderMultiColumnFlowThread() (recalculateColumnHeights()), and soon (once we have support for multiple column sets) this isn't going to be strictly about balancing anyway. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173368

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	Source/core/rendering/RenderMultiColumnFlowThread.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderMultiColumnFlowThread.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnSet.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnSet.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

lgtm https://codereview.chromium.org/264773018/diff/1/Source/core/rendering/RenderMultiColumnSet.h File Source/core/rendering/RenderMultiColumnSet.h (right): https://codereview.chromium.org/264773018/diff/1/Source/core/rendering/RenderMultiColumnSet.h#newcode91 Source/core/rendering/RenderMultiColumnSet.h:91: // (Re-)calculate the column height when contents are ...

6 years, 7 months ago (2014-05-05 21:49:19 UTC) #2

mstensho (USE GERRIT)

https://codereview.chromium.org/264773018/diff/1/Source/core/rendering/RenderMultiColumnSet.h File Source/core/rendering/RenderMultiColumnSet.h (right): https://codereview.chromium.org/264773018/diff/1/Source/core/rendering/RenderMultiColumnSet.h#newcode91 Source/core/rendering/RenderMultiColumnSet.h:91: // (Re-)calculate the column height when contents are supposed ...

6 years, 7 months ago (2014-05-06 07:43:18 UTC) #4

mstensho (USE GERRIT)

The CQ bit was checked by mstensho@opera.com

6 years, 7 months ago (2014-05-06 07:43:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/264773018/10001

6 years, 7 months ago (2014-05-06 07:43:32 UTC) #6

Message was sent while issue was closed.

Change committed as 173368

Expand Messages | Collapse Messages