Issue 264773015: Oilpan: fix build after r173245.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264773015: Oilpan: fix build after r173245. (Closed)

Created:
6 years, 7 months ago by sof

Modified:
6 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r173245. Remove unused allocation of a TouchList object. R= BUG=363321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173271

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/page/EventHandler.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/264773015/1

6 years, 7 months ago (2014-05-03 11:09:05 UTC) #4

Rick Byers

On 2014/05/03 11:09:05, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

6 years, 7 months ago (2014-05-03 22:50:58 UTC) #5

sof

6 years, 7 months ago (2014-05-04 18:38:46 UTC) #7

Message was sent while issue was closed.

On 2014/05/03 22:50:58, Rick Byers wrote:
> On 2014/05/03 11:09:05, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/sigbjornf@opera.com/264773015/1
> 
> Thanks for fixing this, sorry I missed it!

No problem, the use of a RefPtr<> makes such unused objects harder to spot &
Oilpan build failures are for Oilpan-focused folks to clear up for the time
being.

Expand Messages | Collapse Messages