Issue 264773007: Remove Sync FakeServer standalone executable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264773007: Remove Sync FakeServer standalone executable (Closed)

Created:
6 years, 7 months ago by pval...(no longer on Chromium)

Modified:
6 years, 7 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, resetswitch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove Sync FakeServer standalone executable This code was created with the intention of being used in Android tests, but it has gone unused to this point. This qualifies as dead code right now, but we may bring it back in the future. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267686

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -213 lines)			Patch
M	sync/sync_tests.gypi	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	sync/test/fake_server/fake_sync_server_http_handler.h	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	sync/test/fake_server/fake_sync_server_http_handler.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	sync/test/fake_server/run_sync_fake_server.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rlarocque

On 2014/05/01 18:38:50, pvalenzuela wrote: I'm always in favor of deleting dead code. LGTM!

6 years, 7 months ago (2014-05-01 18:52:54 UTC) #2

pval...(no longer on Chromium)

The CQ bit was checked by pvalenzuela@chromium.org

6 years, 7 months ago (2014-05-01 20:41:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/264773007/1

6 years, 7 months ago (2014-05-01 20:43:15 UTC) #4

Message was sent while issue was closed.

Change committed as 267686

Expand Messages | Collapse Messages