Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Side by Side Diff: src/arm64/cpu-arm64.cc

Issue 264773004: Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/cpu-arm64.h ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // CPU specific code for arm independent of OS goes here. 5 // CPU specific code for arm independent of OS goes here.
6 6
7 #include "v8.h" 7 #include "v8.h"
8 8
9 #if V8_TARGET_ARCH_ARM64 9 #if V8_TARGET_ARCH_ARM64
10 10
11 #include "arm64/cpu-arm64.h" 11 #include "arm64/cpu-arm64.h"
12 #include "arm64/utils-arm64.h" 12 #include "arm64/utils-arm64.h"
13 13
14 namespace v8 { 14 namespace v8 {
15 namespace internal { 15 namespace internal {
16 16
17 #ifdef DEBUG 17 #ifdef DEBUG
18 bool CpuFeatures::initialized_ = false; 18 bool CpuFeatures::initialized_ = false;
19 #endif 19 #endif
20 unsigned CpuFeatures::supported_ = 0; 20 unsigned CpuFeatures::supported_ = 0;
21 unsigned CpuFeatures::found_by_runtime_probing_only_ = 0;
21 unsigned CpuFeatures::cross_compile_ = 0; 22 unsigned CpuFeatures::cross_compile_ = 0;
22 23
23 24
24 class CacheLineSizes { 25 class CacheLineSizes {
25 public: 26 public:
26 CacheLineSizes() { 27 CacheLineSizes() {
27 #ifdef USE_SIMULATOR 28 #ifdef USE_SIMULATOR
28 cache_type_register_ = 0; 29 cache_type_register_ = 0;
29 #else 30 #else
30 // Copy the content of the cache type register to a core register. 31 // Copy the content of the cache type register to a core register.
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 [end] "r" (end) 120 [end] "r" (end)
120 // This code does not write to memory but without the dependency gcc might 121 // This code does not write to memory but without the dependency gcc might
121 // move this code before the code is generated. 122 // move this code before the code is generated.
122 : "cc", "memory" 123 : "cc", "memory"
123 ); // NOLINT 124 ); // NOLINT
124 #endif 125 #endif
125 } 126 }
126 127
127 128
128 void CpuFeatures::Probe(bool serializer_enabled) { 129 void CpuFeatures::Probe(bool serializer_enabled) {
129 // AArch64 has no configuration options, no further probing is required. 130 ASSERT(supported_ == 0);
130 supported_ = 0; 131
132 if (serializer_enabled && FLAG_enable_always_align_csp) {
133 // Always align csp in snapshot code - this is safe and ensures that csp
134 // will always be aligned if it is enabled by probing at runtime.
135 supported_ |= static_cast<uint64_t>(1) << ALWAYS_ALIGN_CSP;
136 }
137
138 if (!serializer_enabled) {
139 CPU cpu;
140 // Always align csp on Nvidia cores.
141 if (cpu.implementer() == CPU::NVIDIA && FLAG_enable_always_align_csp) {
142 found_by_runtime_probing_only_ |=
143 static_cast<uint64_t>(1) << ALWAYS_ALIGN_CSP;
144 }
145
146 supported_ |= found_by_runtime_probing_only_;
147 }
131 148
132 #ifdef DEBUG 149 #ifdef DEBUG
133 initialized_ = true; 150 initialized_ = true;
134 #endif 151 #endif
135 } 152 }
136 153
137 154
138 } } // namespace v8::internal 155 } } // namespace v8::internal
139 156
140 #endif // V8_TARGET_ARCH_ARM64 157 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/cpu-arm64.h ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698