Issue 264773002: Start moving WebUserMediaClient on the chromium side to be per frame instead of view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264773002: Start moving WebUserMediaClient on the chromium side to be per frame instead of view. (Closed)

Created:
6 years, 7 months ago by jam

Modified:
6 years, 7 months ago

Reviewers:
nasko

CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Start moving WebUserMediaClient on the chromium side to be per frame instead of view. This is by no means complete, and I've added a bunch of usage of "render_view_" in the code that moved to RenderFrameImpl so that the change doesn't become too big. I will remove these in future cls. BUG=304341 R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267605 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268090

Patch Set 1 : #

Patch Set 2 : fix android #

Patch Set 3 : sync #

Patch Set 4 : reland after revert, also with r267629 #

Patch Set 5 : fix #

Patch Set 6 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+245 lines, -258 lines)			Patch
M	content/browser/web_contents/web_contents_impl.h	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2 3	8 chunks	+11 lines, -12 lines	0 comments	Download
M	content/common/frame_messages.h	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 2 3	1 chunk	+0 lines, -8 lines	0 comments	Download
M	content/public/renderer/render_view_observer.h	View	1 2 3	2 chunks	+0 lines, -3 lines	0 comments	Download
M	content/public/test/layouttest_support.h	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/render_frame_impl.h	View	1 2 3	9 chunks	+36 lines, -3 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2 3	10 chunks	+161 lines, -7 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 2 3	13 chunks	+1 line, -42 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3	13 chunks	+0 lines, -163 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebFrameTestProxy.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/shell/renderer/webkit_test_runner.cc	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/test/layouttest_support.cc	View	1 2 3	3 chunks	+8 lines, -4 lines	0 comments	Download
M	content/test/test_media_stream_client.h	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/test/test_media_stream_client.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages