Issue 26477002: Android WebView: post QuotaManager calls to UI thread.

Issue 26477002: Android WebView: post QuotaManager calls to UI thread. (Closed)

Created:
7 years, 2 months ago by Torne

Modified:
7 years, 2 months ago

Reviewers:
benm (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android WebView: post QuotaManager calls to UI thread. The AwQuotaManagerBridge needs to be usable from any thread, not just the UI thread. Make it refcounted and have its methods post to the UI thread if not already there. Since none of the methods are synchronous there's no need to wait for the posted messages to be handled. BUG=305205 R=benm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227508

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix missing origin in url construction #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -15 lines)			Patch
M	android_webview/browser/aw_browser_context.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/browser/aw_browser_context.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	android_webview/browser/aw_quota_manager_bridge.h	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	android_webview/browser/aw_quota_manager_bridge.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	android_webview/browser/jni_dependency_factory.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	android_webview/lib/main/aw_main_delegate.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	android_webview/lib/main/aw_main_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	android_webview/native/aw_quota_manager_bridge_impl.h	View		3 chunks	+13 lines, -2 lines	0 comments	Download
M	android_webview/native/aw_quota_manager_bridge_impl.cc	View	1	8 chunks	+51 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

benm (inactive)

https://codereview.chromium.org/26477002/diff/1/android_webview/native/aw_quota_manager_bridge_impl.cc File android_webview/native/aw_quota_manager_bridge_impl.cc (right): https://codereview.chromium.org/26477002/diff/1/android_webview/native/aw_quota_manager_bridge_impl.cc#newcode333 android_webview/native/aw_quota_manager_bridge_impl.cc:333: GURL(), origin?

7 years, 2 months ago (2013-10-08 11:30:11 UTC) #2

Torne

7 years, 2 months ago (2013-10-08 11:43:45 UTC) #3

Torne

7 years, 2 months ago (2013-10-08 12:56:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r227508 (presubmit successful).

Expand Messages | Collapse Messages