chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc - Issue 2647683002: Consolidate Origin- and RegistrableDomain- FilterBuilder into one class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

Issue 2647683002: Consolidate Origin- and RegistrableDomain- FilterBuilder into one class (Closed)

Patch Set: Rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc ('k') | chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

index c2e79d00fa7963037e40a316c2250b997e38bb12..8963d7946119db049d44836086f909349f50a27d 100644

--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

@@ -14,7 +14,6 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/browsing_data/browsing_data_filter_builder.h"

#include "chrome/browser/browsing_data/browsing_data_helper.h"

-#include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

#include "chrome/browser/domain_reliability/service_factory.h"

@@ -389,7 +388,7 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(

// Therefore, clearing history for a small set of origins (WHITELIST) should

// never delete any extension launch times, while clearing for almost all

// origins (BLACKLIST) should always delete all of extension launch times.

- if (filter_builder.mode() == BrowsingDataFilterBuilder::BLACKLIST) {

+ if (filter_builder.GetMode() == BrowsingDataFilterBuilder::BLACKLIST) {

extensions::ExtensionPrefs* extension_prefs =

extensions::ExtensionPrefs::Get(profile_);

extension_prefs->ClearLastLaunchTimes();