Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_impl.cc

Issue 2647683002: Consolidate Origin- and RegistrableDomain- FilterBuilder into one class (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover_impl.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/bind_helpers.h" 13 #include "base/bind_helpers.h"
14 #include "base/callback.h" 14 #include "base/callback.h"
15 #include "base/logging.h" 15 #include "base/logging.h"
16 #include "base/memory/ptr_util.h" 16 #include "base/memory/ptr_util.h"
17 #include "base/metrics/histogram_macros.h" 17 #include "base/metrics/histogram_macros.h"
18 #include "chrome/browser/browsing_data/browsing_data_filter_builder.h" 18 #include "chrome/browser/browsing_data/browsing_data_filter_builder.h"
19 #include "chrome/browser/browsing_data/browsing_data_helper.h" 19 #include "chrome/browser/browsing_data/browsing_data_helper.h"
20 #include "chrome/browser/browsing_data/browsing_data_remover_delegate.h" 20 #include "chrome/browser/browsing_data/browsing_data_remover_delegate.h"
21 #include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"
22 #include "chrome/browser/profiles/profile.h" 21 #include "chrome/browser/profiles/profile.h"
23 #include "chrome/common/pref_names.h" 22 #include "chrome/common/pref_names.h"
24 #include "components/browsing_data/content/storage_partition_http_cache_data_rem over.h" 23 #include "components/browsing_data/content/storage_partition_http_cache_data_rem over.h"
25 #include "components/prefs/pref_service.h" 24 #include "components/prefs/pref_service.h"
26 #include "components/web_cache/browser/web_cache_manager.h" 25 #include "components/web_cache/browser/web_cache_manager.h"
27 #include "content/public/browser/browser_context.h" 26 #include "content/public/browser/browser_context.h"
28 #include "content/public/browser/browser_thread.h" 27 #include "content/public/browser/browser_thread.h"
29 #include "content/public/browser/content_browser_client.h" 28 #include "content/public/browser/content_browser_client.h"
30 #include "content/public/browser/download_manager.h" 29 #include "content/public/browser/download_manager.h"
31 #include "content/public/browser/notification_service.h" 30 #include "content/public/browser/notification_service.h"
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 BrowsingDataRemoverDelegate* 201 BrowsingDataRemoverDelegate*
203 BrowsingDataRemoverImpl::GetEmbedderDelegate() const { 202 BrowsingDataRemoverImpl::GetEmbedderDelegate() const {
204 return embedder_delegate_.get(); 203 return embedder_delegate_.get();
205 } 204 }
206 205
207 void BrowsingDataRemoverImpl::Remove(const base::Time& delete_begin, 206 void BrowsingDataRemoverImpl::Remove(const base::Time& delete_begin,
208 const base::Time& delete_end, 207 const base::Time& delete_end,
209 int remove_mask, 208 int remove_mask,
210 int origin_type_mask) { 209 int origin_type_mask) {
211 RemoveInternal(delete_begin, delete_end, remove_mask, origin_type_mask, 210 RemoveInternal(delete_begin, delete_end, remove_mask, origin_type_mask,
212 std::unique_ptr<RegistrableDomainFilterBuilder>(), nullptr); 211 std::unique_ptr<BrowsingDataFilterBuilder>(), nullptr);
213 } 212 }
214 213
215 void BrowsingDataRemoverImpl::RemoveAndReply( 214 void BrowsingDataRemoverImpl::RemoveAndReply(
216 const base::Time& delete_begin, 215 const base::Time& delete_begin,
217 const base::Time& delete_end, 216 const base::Time& delete_end,
218 int remove_mask, 217 int remove_mask,
219 int origin_type_mask, 218 int origin_type_mask,
220 Observer* observer) { 219 Observer* observer) {
221 DCHECK(observer); 220 DCHECK(observer);
222 RemoveInternal(delete_begin, delete_end, remove_mask, origin_type_mask, 221 RemoveInternal(delete_begin, delete_end, remove_mask, origin_type_mask,
223 std::unique_ptr<RegistrableDomainFilterBuilder>(), observer); 222 std::unique_ptr<BrowsingDataFilterBuilder>(), observer);
224 } 223 }
225 224
226 void BrowsingDataRemoverImpl::RemoveWithFilter( 225 void BrowsingDataRemoverImpl::RemoveWithFilter(
227 const base::Time& delete_begin, 226 const base::Time& delete_begin,
228 const base::Time& delete_end, 227 const base::Time& delete_end,
229 int remove_mask, 228 int remove_mask,
230 int origin_type_mask, 229 int origin_type_mask,
231 std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) { 230 std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) {
232 DCHECK_EQ(0, remove_mask & ~FILTERABLE_DATATYPES); 231 DCHECK_EQ(0, remove_mask & ~FILTERABLE_DATATYPES);
233 DCHECK(filter_builder); 232 DCHECK(filter_builder);
(...skipping 22 matching lines...) Expand all
256 int origin_type_mask, 255 int origin_type_mask,
257 std::unique_ptr<BrowsingDataFilterBuilder> filter_builder, 256 std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
258 Observer* observer) { 257 Observer* observer) {
259 DCHECK(!observer || observer_list_.HasObserver(observer)) 258 DCHECK(!observer || observer_list_.HasObserver(observer))
260 << "Every observer must register itself (by calling AddObserver()) " 259 << "Every observer must register itself (by calling AddObserver()) "
261 << "before observing a removal task."; 260 << "before observing a removal task.";
262 261
263 // Remove() and RemoveAndReply() pass a null pointer to indicate no filter. 262 // Remove() and RemoveAndReply() pass a null pointer to indicate no filter.
264 // No filter is equivalent to one that |IsEmptyBlacklist()|. 263 // No filter is equivalent to one that |IsEmptyBlacklist()|.
265 if (!filter_builder) { 264 if (!filter_builder) {
266 filter_builder = base::MakeUnique<RegistrableDomainFilterBuilder>( 265 filter_builder = BrowsingDataFilterBuilder::Create(
267 RegistrableDomainFilterBuilder::BLACKLIST); 266 BrowsingDataFilterBuilder::BLACKLIST);
268 DCHECK(filter_builder->IsEmptyBlacklist()); 267 DCHECK(filter_builder->IsEmptyBlacklist());
269 } 268 }
270 269
271 task_queue_.emplace( 270 task_queue_.emplace(
272 delete_begin, 271 delete_begin,
273 delete_end, 272 delete_end,
274 remove_mask, 273 remove_mask,
275 origin_type_mask, 274 origin_type_mask,
276 std::move(filter_builder), 275 std::move(filter_builder),
277 observer); 276 observer);
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 652
654 if (completion_inhibitor_) { 653 if (completion_inhibitor_) {
655 completion_inhibitor_->OnBrowsingDataRemoverWouldComplete( 654 completion_inhibitor_->OnBrowsingDataRemoverWouldComplete(
656 this, base::Bind(&BrowsingDataRemoverImpl::Notify, 655 this, base::Bind(&BrowsingDataRemoverImpl::Notify,
657 weak_ptr_factory_.GetWeakPtr())); 656 weak_ptr_factory_.GetWeakPtr()));
658 return; 657 return;
659 } 658 }
660 659
661 Notify(); 660 Notify();
662 } 661 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698