Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)
Patch Set: add TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
index 222b1e2c748402a87d1cd63d6dbd4ceacee1f235..a92c75e1396de02f7a606d0c5422766dab070d18 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
@@ -65,9 +65,8 @@ class CORE_EXPORT PerformanceResourceTiming : public PerformanceEntry {
return new PerformanceResourceTiming(info, timeOrigin, startTime, 0.0,
allowTimingDetails, false);
}
-
- AtomicString initiatorType() const;
-
+ // Related doc: https://goo.gl/uNecAj.
+ virtual AtomicString initiatorType() const;
DOMHighResTimeStamp workerStart() const;
virtual DOMHighResTimeStamp redirectStart() const;
virtual DOMHighResTimeStamp redirectEnd() const;
@@ -87,20 +86,12 @@ class CORE_EXPORT PerformanceResourceTiming : public PerformanceEntry {
protected:
void buildJSONValue(V8ObjectBuilder&) const override;
- PerformanceResourceTiming(const AtomicString& initiatorType,
- double timeOrigin,
- ResourceLoadTiming*,
- double lastRedirectEndTime,
- double finishTime,
- unsigned long long transferSize,
- unsigned long long encodedBodyLength,
- unsigned long long decodedBodyLength,
- bool didReuseConnection,
- bool allowTimingDetails,
- bool allowRedirectDetails,
- const String& name,
+ // This constructor is for PerformanceNavigationTiming.
+ // Related doc: https://goo.gl/uNecAj.
+ PerformanceResourceTiming(const String& name,
const String& entryType,
- double startTime);
+ double startTime,
+ double duration);
private:
PerformanceResourceTiming(const ResourceTimingInfo&,
@@ -112,6 +103,13 @@ class CORE_EXPORT PerformanceResourceTiming : public PerformanceEntry {
double workerReady() const;
+ virtual ResourceLoadTiming* resourceLoadTiming() const;
+ virtual bool allowTimingDetails() const;
+ virtual bool didReuseConnection() const;
+ virtual unsigned long long getTransferSize() const;
+ virtual unsigned long long getEncodedBodySize() const;
+ virtual unsigned long long getDecodedBodySize() const;
+
AtomicString m_initiatorType;
double m_timeOrigin;
RefPtr<ResourceLoadTiming> m_timing;

Powered by Google App Engine
This is Rietveld 408576698