third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2647643004: Report nav timing 2 instance as soon as it's requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)

Patch Set: addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index eb7c4079d2485bb46480aadf9455bdd30b5178cb..a9c51bba8793ac3450e1d974f3b333e69342a581 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -1481,7 +1481,7 @@ void LocalDOMWindow::dispatchLoadEvent() {

if (frame()) {

Performance* performance = DOMWindowPerformance::performance(*this);

DCHECK(performance);

- performance->addNavigationTiming(frame());

+ performance->notifyNavigationTimingToObservers();

}

// For load events, send a separate load event to the enclosing frame only.