Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)
Patch Set: make ResourceTimingInfo ref-counted Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
index 8e47ccb2e3c325349a02dafa5f234703df0acd47..0c730f05169a3d2af94f4f80b08e3d1315359cca 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
@@ -142,6 +142,7 @@ class PLATFORM_EXPORT ResourceFetcher
void reloadLoFiImages();
// Calling this method before main document resource is fetched is invalid.
+ // This method should only be called once.
Kunihiko Sakamoto 2017/02/13 08:22:29 Now this can be called multiple times safely.
sunjian 2017/02/14 21:29:03 Done.
ResourceTimingInfo* getNavigationTimingInfo();
// This is only exposed for testing purposes.
@@ -230,12 +231,12 @@ class PLATFORM_EXPORT ResourceFetcher
TaskRunnerTimer<ResourceFetcher> m_resourceTimingReportTimer;
using ResourceTimingInfoMap =
- HeapHashMap<Member<Resource>, std::unique_ptr<ResourceTimingInfo>>;
+ HeapHashMap<Member<Resource>, RefPtr<ResourceTimingInfo>>;
ResourceTimingInfoMap m_resourceTimingInfoMap;
- std::unique_ptr<ResourceTimingInfo> m_navigationTimingInfo;
+ RefPtr<ResourceTimingInfo> m_navigationTimingInfo;
- Vector<std::unique_ptr<ResourceTimingInfo>> m_scheduledResourceTimingReports;
+ Vector<RefPtr<ResourceTimingInfo>> m_scheduledResourceTimingReports;
HeapHashSet<Member<ResourceLoader>> m_loaders;
HeapHashSet<Member<ResourceLoader>> m_nonBlockingLoaders;

Powered by Google App Engine
This is Rietveld 408576698