Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)
Patch Set: make ResourceTimingInfo ref-counted Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index 2cbe04647df76423697db029fa893b958c932f16..9fd97b009c2da5cc2e092ae850af12fc5003af6b 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -62,12 +62,6 @@ class PerformanceBaseTest : public ::testing::Test {
return m_observer->m_performanceEntries.size();
}
- PerformanceNavigationTiming::NavigationType getNavigationType(
- NavigationType type,
- Document* document) {
- return PerformanceBase::getNavigationType(type, document);
- }
-
static bool allowsTimingRedirect(
const Vector<ResourceResponse>& redirectChain,
const ResourceResponse& finalResponse,
@@ -145,26 +139,6 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
EXPECT_EQ(1, numPerformanceEntriesInObserver()); // added an entry
}
-TEST_F(PerformanceBaseTest, GetNavigationType) {
- m_pageHolder->page().setVisibilityState(PageVisibilityStatePrerender, false);
- PerformanceNavigationTiming::NavigationType returnedType =
- getNavigationType(NavigationTypeBackForward, &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::Prerender);
-
- m_pageHolder->page().setVisibilityState(PageVisibilityStateHidden, false);
- returnedType =
- getNavigationType(NavigationTypeBackForward, &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::BackForward);
-
- m_pageHolder->page().setVisibilityState(PageVisibilityStateVisible, false);
- returnedType = getNavigationType(NavigationTypeFormResubmitted,
- &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::Navigate);
-}
-
TEST_F(PerformanceBaseTest, AllowsTimingRedirect) {
// When there are no cross-origin redirects.
AtomicString originDomain = "http://127.0.0.1:8000";

Powered by Google App Engine
This is Rietveld 408576698