third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp - Issue 2647643004: Report nav timing 2 instance as soon as it's requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)

Patch Set: make a copy of navigationTimingInfo for ResourceFetcher Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp ('K') | « third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

index 5159d4ec955ce15bebeaab04347537380cd8993b..94146e74d6d7a6a68d2d5e933d6256745f620a2c 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

@@ -173,7 +173,8 @@ TEST_F(ResourceFetcherTest, NavigationTimingInfo) {

resource->responseReceived(response, nullptr);

EXPECT_EQ(resource->getType(), Resource::MainResource);

- ResourceTimingInfo* navigationTimingInfo = fetcher->getNavigationTimingInfo();

+ std::unique_ptr<ResourceTimingInfo> navigationTimingInfo =

+ fetcher->getNavigationTimingInfo();

ASSERT_TRUE(navigationTimingInfo);

long long encodedDataLength = 123;

resource->loader()->didFinishLoading(0.0, encodedDataLength, 0);