Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)
Patch Set: make a copy of navigationTimingInfo for ResourceFetcher Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
index 222b1e2c748402a87d1cd63d6dbd4ceacee1f235..755afdde5a0162b26a8e16aad9db8de212b819e5 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
@@ -66,41 +66,31 @@ class CORE_EXPORT PerformanceResourceTiming : public PerformanceEntry {
allowTimingDetails, false);
}
panicker 2017/02/03 23:53:52 Add link to design doc ...
sunjian 2017/02/10 18:32:46 Done.
- AtomicString initiatorType() const;
-
- DOMHighResTimeStamp workerStart() const;
+ virtual AtomicString initiatorType() const;
+ virtual DOMHighResTimeStamp workerStart() const;
virtual DOMHighResTimeStamp redirectStart() const;
virtual DOMHighResTimeStamp redirectEnd() const;
virtual DOMHighResTimeStamp fetchStart() const;
- DOMHighResTimeStamp domainLookupStart() const;
- DOMHighResTimeStamp domainLookupEnd() const;
- DOMHighResTimeStamp connectStart() const;
- DOMHighResTimeStamp connectEnd() const;
- DOMHighResTimeStamp secureConnectionStart() const;
- DOMHighResTimeStamp requestStart() const;
- DOMHighResTimeStamp responseStart() const;
+ virtual DOMHighResTimeStamp domainLookupStart() const;
+ virtual DOMHighResTimeStamp domainLookupEnd() const;
+ virtual DOMHighResTimeStamp connectStart() const;
+ virtual DOMHighResTimeStamp connectEnd() const;
+ virtual DOMHighResTimeStamp secureConnectionStart() const;
+ virtual DOMHighResTimeStamp requestStart() const;
+ virtual DOMHighResTimeStamp responseStart() const;
virtual DOMHighResTimeStamp responseEnd() const;
- unsigned long long transferSize() const;
- unsigned long long encodedBodySize() const;
- unsigned long long decodedBodySize() const;
+ virtual unsigned long long transferSize() const;
+ virtual unsigned long long encodedBodySize() const;
+ virtual unsigned long long decodedBodySize() const;
protected:
void buildJSONValue(V8ObjectBuilder&) const override;
- PerformanceResourceTiming(const AtomicString& initiatorType,
- double timeOrigin,
- ResourceLoadTiming*,
- double lastRedirectEndTime,
- double finishTime,
- unsigned long long transferSize,
- unsigned long long encodedBodyLength,
- unsigned long long decodedBodyLength,
- bool didReuseConnection,
- bool allowTimingDetails,
- bool allowRedirectDetails,
- const String& name,
+ // This constructor is for PerformanceNavigationTiming.
+ PerformanceResourceTiming(const String& name,
const String& entryType,
- double startTime);
+ double startTime,
+ double duration);
private:
PerformanceResourceTiming(const ResourceTimingInfo&,

Powered by Google App Engine
This is Rietveld 408576698