Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.h

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)
Patch Set: make a copy of navigationTimingInfo for ResourceFetcher Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceEntry.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.h b/third_party/WebKit/Source/core/timing/PerformanceEntry.h
index e3b75748617f6286a07b57ba6b46d3d9cbec66a3..7b90c309d09200369a44b126fbd8fc0ca11b7ea2 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.h
@@ -71,7 +71,10 @@ class CORE_EXPORT PerformanceEntry
String name() const;
String entryType() const;
DOMHighResTimeStamp startTime() const;
- DOMHighResTimeStamp duration() const;
+ // PerformanceNavigationTiming will override this due to
+ // the nature of reporting it early, which means not having a
+ // finish time available at construction time.
panicker 2017/02/03 23:53:52 Add: // Other classes must NOT override this.
sunjian 2017/02/10 18:32:46 Done.
+ virtual DOMHighResTimeStamp duration() const;
ScriptValue toJSONForBinding(ScriptState*) const;

Powered by Google App Engine
This is Rietveld 408576698