third_party/WebKit/Source/core/timing/PerformanceEntry.h - Issue 2647643004: Report nav timing 2 instance as soon as it's requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.h

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)

Patch Set: got rid of test cases that don't apply anymore Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/PerformanceEntry.h

diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.h b/third_party/WebKit/Source/core/timing/PerformanceEntry.h

index e3b75748617f6286a07b57ba6b46d3d9cbec66a3..7b90c309d09200369a44b126fbd8fc0ca11b7ea2 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.h

+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.h

@@ -71,7 +71,10 @@ class CORE_EXPORT PerformanceEntry

String name() const;

String entryType() const;

DOMHighResTimeStamp startTime() const;

- DOMHighResTimeStamp duration() const;

+ // PerformanceNavigationTiming will override this due to

+ // the nature of reporting it early, which means not having a

+ // finish time available at construction time.

+ virtual DOMHighResTimeStamp duration() const;

ScriptValue toJSONForBinding(ScriptState*) const;