third_party/WebKit/LayoutTests/http/tests/performance-timing/nav2-test-instance-accessible-from-the-start.html - Issue 2647643004: Report nav timing 2 instance as soon as it's requested.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/nav2-test-instance-accessible-from-the-start.html

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)

Patch Set: addressed comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_open_data_uri.html ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>
	panicker 2017/03/10 21:46:36 move this under web-platform-tests in external/wpt move this under web-platform-tests in external/wpt/ ? sunjian 2017/03/13 19:08:18 I thought of doing this. But i am not sure whether Show quoted text On 2017/03/10 21:46:36, panicker wrote: > move this under web-platform-tests in external/wpt/ ? I thought of doing this. But i am not sure whether this feature will apply to other browsers. Let me know if you think it's okay to move it to external/wpt/. panicker 2017/03/13 20:42:40 Yes it's fine to move to external/wpt/ as this is Show quoted text On 2017/03/13 19:08:18, sunjian wrote: > On 2017/03/10 21:46:36, panicker wrote: > > move this under web-platform-tests in external/wpt/ ? > > I thought of doing this. But i am not sure whether this feature will apply to > other browsers. > Let me know if you think it's okay to move it to external/wpt/. Yes it's fine to move to external/wpt/ as this is part of the spec for NT2. sunjian 2017/03/14 18:36:58 Done. Show quoted text On 2017/03/13 20:42:40, panicker wrote: > On 2017/03/13 19:08:18, sunjian wrote: > > On 2017/03/10 21:46:36, panicker wrote: > > > move this under web-platform-tests in external/wpt/ ? > > > > I thought of doing this. But i am not sure whether this feature will apply to > > other browsers. > > Let me know if you think it's okay to move it to external/wpt/. > > Yes it's fine to move to external/wpt/ as this is part of the spec for NT2. Done.
	5 test(function() {

	6 var navigationTiming2 = window.performance.getEntriesByType('navigation' )[0];

	7 assert_true(navigationTiming2 !== undefined);

	8 assert_equals(navigationTiming2.entryType, "navigation");

	9 assert_equals(navigationTiming2.startTime, 0);

	10 assert_equals(navigationTiming2.initiatorType, "navigation");

	11 done();

	12 }, "PerformanceNavigationTiming instance exists with reasonable values.");

	13 </script>

OLD	NEW