third_party/WebKit/LayoutTests/http/tests/performance-timing/nav2-test-instance-accessible-from-the-start.html - Issue 2647643004: Report nav timing 2 instance as soon as it's requested.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/nav2-test-instance-accessible-from-the-start.html

Issue 2647643004: Report nav timing 2 instance as soon as it's requested. (Closed)

Patch Set: addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var navigationTiming2 = window.performance.getEntriesByType('navigation');

	6 assert_true(navigationTiming2 !== undefined);
	Kunihiko Sakamoto 2017/03/10 08:19:00 Please write assertions inside test(). https://git Please write assertions inside test(). https://github.com/w3c/testharness.js/blob/master/docs/api.md Also, could we test that some fields have reasonable values? sunjian 2017/03/10 20:40:17 Done. Show quoted text On 2017/03/10 08:19:00, Kunihiko Sakamoto wrote: > Please write assertions inside test(). > https://github.com/w3c/testharness.js/blob/master/docs/api.md > > Also, could we test that some fields have reasonable values? Done.
	7 done();

	8 </script>

OLD	NEW