third_party/WebKit/Source/bindings/templates/interface.h.tmpl - Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)

Patch Set: Review feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

index a828a5de7042f9f22f7fbf1783b537a1941c8dcb..e026bf2b405e5a154e86bcf6e073c20065305a91 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

@@ -21,6 +21,8 @@ class {{v8_class}}Constructor {

STATIC_ONLY({{v8_class}}Constructor);

public:

static v8::Local<v8::FunctionTemplate> domTemplate(v8::Isolate*, const DOMWrapperWorld&);

+ static v8::Local<v8::FunctionTemplate> NamedConstructorAttributeGetter(v8::Isolate*, const DOMWrapperWorld&);

haraken 2017/01/25 03:37:16 Is this needed?

sashab 2017/01/25 04:54:15 Nope :) Removed.

+ static void NamedConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::PropertyCallbackInfo<v8::Value>& info);

{{exported}}static const WrapperTypeInfo wrapperTypeInfo;

};