third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)

Patch Set: Review feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index c72c8e23aeca3741dcc44a9b2aca44de74704ff7..bdf0f62d1e54188850249106ce4083b48bd45485 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -330,6 +330,8 @@ def interface_context(interface, interfaces):

raise Exception('[Constructor] and [NamedConstructor] MUST NOT be'

' specified on partial interface definitions: '

'%s' % interface.name)

+ if named_constructor:

+ includes.add('bindings/core/v8/V8PrivateProperty.h')

includes.add('bindings/core/v8/V8ObjectConstructor.h')

includes.add('core/frame/LocalDOMWindow.h')