Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)
Patch Set: Fixed failing test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
index 7550a07909499b173d56cb0f3785aa515d5d03f8..f940e18f75e7efba06f9a80fb24b7122e9c35f36 100644
--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
@@ -426,7 +426,9 @@ const v8::FunctionCallbackInfo<v8::Value>& info
{% set getter_callback =
'%sV8Internal::%sConstructorGetterCallback' % (cpp_class_or_partial, attribute.name)
if attribute.needs_constructor_getter_callback else
- 'v8ConstructorAttributeGetter' %}
+ ('V8%s::NamedConstructorAttributeGetter' % (attribute.constructor_type)
+ if attribute.is_named_constructor else
+ 'v8ConstructorAttributeGetter') %}
{% set setter_callback = '0' %}
{% else %}{# regular attributes #}
{% set getter_callback = '%sV8Internal::%sAttributeGetterCallback' %

Powered by Google App Engine
This is Rietveld 408576698