Chromium Code Reviews Chromium Code Reviews
Issue 2647643002:
Fix V8 bindings for named constructors to set prototype object correctly (Closed)
| Index: third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html b/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..e22af9d025431730cdc1a76247a1d7ade97a5f3c |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html |
| @@ -0,0 +1,13 @@ |
| +<!DOCTYPE html> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script> |
| +test(function(t) |
| +{ |
| + assert_equals(Image.name, "Image", "Image name should be Image (not HTMLImageElement)"); |
|
sashab
2017/01/20 04:37:05
This was failing - fixed by updating setClassName(
|
| + assert_equals(Image.__proto__, HTMLElement, "Image __proto__ is HTMLElement"); |
|
sashab
2017/01/20 04:37:05
This test fails with the error:
FAIL NamedConstruc
|
| + assert_equals(Image.prototype, HTMLImageElement.prototype, "Image.prototype is same as HTMLImageElement.prototype"); |
| + assert_equals(new Image().__proto__, HTMLImageElement.prototype, "Image __proto__ is HTMLImageElement prototype "); |
| + assert_equals(Image.prototype.__proto__, HTMLElement.prototype, "Image.prototype __proto__ is HTMLElement prototype"); |
| +}, "NamedConstructor creates the correct object structure."); |
| +</script> |
