Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
index a2cfd7a60dbb4eb07c1111af8d47bdb517a4feb4..68bb1dc2439e5676790c95615c112476d581317a 100644
--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
@@ -426,7 +426,9 @@ const v8::FunctionCallbackInfo<v8::Value>& info
{% set getter_callback =
'%sV8Internal::%sConstructorGetterCallback' % (cpp_class_or_partial, attribute.name)
if attribute.needs_constructor_getter_callback else
- 'v8ConstructorAttributeGetter' %}
+ ('V8%s::NamedConstructorAttributeGetter' % (attribute.constructor_type)
+ if attribute.is_named_constructor else
Yuki 2017/01/19 09:57:28 nit: Indent one more space? ('V8%s::...' % (..
sashab 2017/01/20 04:37:05 Good idea -- done.
+ 'v8ConstructorAttributeGetter') %}
{% set setter_callback = '0' %}
{% else %}{# regular attributes #}
{% set getter_callback = '%sV8Internal::%sAttributeGetterCallback' %

Powered by Google App Engine
This is Rietveld 408576698