Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)
Patch Set: Review feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8PrivateProperty_h 5 #ifndef V8PrivateProperty_h
6 #define V8PrivateProperty_h 6 #define V8PrivateProperty_h
7 7
8 #include "bindings/core/v8/ScopedPersistent.h" 8 #include "bindings/core/v8/ScopedPersistent.h"
9 #include "bindings/core/v8/ScriptPromiseProperties.h" 9 #include "bindings/core/v8/ScriptPromiseProperties.h"
10 #include "bindings/core/v8/V8BindingMacros.h" 10 #include "bindings/core/v8/V8BindingMacros.h"
(...skipping 15 matching lines...) Expand all
26 X(CustomElement, ConnectedCallback) \ 26 X(CustomElement, ConnectedCallback) \
27 X(CustomElement, DisconnectedCallback) \ 27 X(CustomElement, DisconnectedCallback) \
28 X(CustomElement, AdoptedCallback) \ 28 X(CustomElement, AdoptedCallback) \
29 X(CustomElement, AttributeChangedCallback) \ 29 X(CustomElement, AttributeChangedCallback) \
30 X(DOMException, Error) \ 30 X(DOMException, Error) \
31 X(ErrorEvent, Error) \ 31 X(ErrorEvent, Error) \
32 X(IDBObserver, Callback) \ 32 X(IDBObserver, Callback) \
33 X(IntersectionObserver, Callback) \ 33 X(IntersectionObserver, Callback) \
34 X(MessageEvent, CachedData) \ 34 X(MessageEvent, CachedData) \
35 X(MutationObserver, Callback) \ 35 X(MutationObserver, Callback) \
36 X(NamedConstructor, Initialized) \
36 X(PerformanceObserver, Callback) \ 37 X(PerformanceObserver, Callback) \
37 X(SameObject, NotificationActions) \ 38 X(SameObject, NotificationActions) \
38 X(SameObject, NotificationData) \ 39 X(SameObject, NotificationData) \
39 X(SameObject, NotificationVibrate) \ 40 X(SameObject, NotificationVibrate) \
40 X(SameObject, PerformanceLongTaskTimingAttribution) \ 41 X(SameObject, PerformanceLongTaskTimingAttribution) \
41 X(V8NodeFilterCondition, Filter) \ 42 X(V8NodeFilterCondition, Filter) \
42 X(Window, DocumentCachedAccessor) 43 X(Window, DocumentCachedAccessor)
43 44
44 // The getter's name for a private property. 45 // The getter's name for a private property.
45 #define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \ 46 #define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \ 175 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \
175 ScopedPersistent<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME( \ 176 ScopedPersistent<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME( \
176 InterfaceName, KeyName); // NOLINT(readability/naming/underscores) 177 InterfaceName, KeyName); // NOLINT(readability/naming/underscores)
177 V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER) 178 V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER)
178 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER 179 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER
179 }; 180 };
180 181
181 } // namespace blink 182 } // namespace blink
182 183
183 #endif // V8PrivateProperty_h 184 #endif // V8PrivateProperty_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698